bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30665: [PATCH, STAGING] guix: ant-build-system: Use manifest task to


From: Marius Bakke
Subject: bug#30665: [PATCH, STAGING] guix: ant-build-system: Use manifest task to create manifest.
Date: Mon, 18 Jun 2018 15:49:52 +0200
User-agent: Notmuch/0.26.2 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu)

Gábor Boskovits <address@hidden> writes:

> ---
>  guix/build/ant-build-system.scm | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/guix/build/ant-build-system.scm b/guix/build/ant-build-system.scm
> index 3ed12b9f4..87c782d85 100644
> --- a/guix/build/ant-build-system.scm
> +++ b/guix/build/ant-build-system.scm
> @@ -68,14 +68,11 @@
>  
>                   (target (@ (name "manifest"))
>                           (mkdir (@ (dir "${manifest.dir}")))
> -                         (echo (@ (file "${manifest.file}")
> -                                  (message ,(string-append
> -                                              (if main-class
> -                                                (string-append
> -                                                  "Main-Class: " main-class
> -                                                  "${line.separator}")
> -                                                "")
> -                                              "")))))
> +                         (manifest (@ (file "${manifest.file}"))
> +                                   ,(if main-class
> +                                       `(attribute (@ (name "Main-Class")
> +                                                      (value ,main-class)))
> +                                       "")))

LGTM.  I was about to push it and start the 'staging' jobset on Hydra,
but I'm not sure what to write in the commit message.  Are you able to
push it soonish?

I'll start Hydra once the current 'master' evaluation finishes.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]