bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44027: [PATCH] installer: Create bios_grub partition when it is need


From: Miguel Ángel Arruga Vivas
Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed.
Date: Sat, 17 Oct 2020 15:09:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi,

Brett Gilio <brettg@gnu.org> writes:
> Ludovic Courtès <ludo@gnu.org> writes:
>> Shouldn’t it create a “legacy” partition table rather than GPT since
>> we’re on an old, non-UEFI platform?
>
> That is my thinking as well, it should create a legacy MBR table.

IMHO the old format should be avoided completely when possible.  Why
should we enforce it?

I think this problem involves having a previous ESP partition on the
disk (at least identified as such by parted), because auto-partition!
currently checks that before checking if the booted system has EFI
support.  When that's the case, it doesn't create the needed bios_grub
partition that might have been removed previously.

The attached patch solves that.  What do you think?

Happy hacking,
Miguel

Attachment: 0001-installer-Create-bios_grub-partition-when-it-is-need.patch
Description: 0001-installer-Create-bios_grub-partition-when-it-is-needed.patch

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]