[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45279: [core-updates] copy-recursively does not throw an error on mi
From: |
Mark H Weaver |
Subject: |
bug#45279: [core-updates] copy-recursively does not throw an error on missing directory |
Date: |
Thu, 17 Dec 2020 15:23:44 -0500 |
Ludovic Courtès <ludo@gnu.org> writes:
> Marius Bakke <marius@gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure. Instead an error is printed
>> and the script continues:
>>
>> (copy-recursively "doesnotexist" output)
>> [...]
>> starting phase `install'
>> i/o error: doesnotexist: No such file or directory
>> phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way. Do you think we should change it?
In general, I think it's a good idea to raise errors for things like
this. Warnings that only end up in build logs are likely to go
unnoticed for a long time.
Mark