bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45570: [PATCH v2] system: Assert, that user and group names are uniq


From: Ludovic Courtès
Subject: bug#45570: [PATCH v2] system: Assert, that user and group names are unique.
Date: Thu, 07 Jan 2021 09:35:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> *gnu/system/shadow.scm (find-duplicates): New variable.
> (assert-unique-account-names, assert-unique-group-names): New variables.
> (account-activation): Use them here.

Final nitpicks!  :-)

> +(define (find-duplicates list)

Please add a docstring.

> +  (let loop ((table (make-hash-table))
> +             (list list))

You can move ‘table’ out of the ‘loop’ arguments since it’s mutated
anyway.

OK with these changes!

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]