bug#50299: [PATCH v2 01/27] lint: check-tests-true: Allow #:tests? #t for some build systems.

[Maxim Cournoyer]

Hello!

Maxime Devos <maximedevos@telenet.be> writes:

> emacs-build-system sets #:tests? #f by default, so the linter
> shouldn't warn if #:tests? #t is set for packages using
> emacs-build-system.  Likewise for texlive-build-system
>
> * guix/lint.scm (check-tests-true): Do not warn if the build system
>   is emacs-build-system or texlive-build-system.
> * tests/lint.scm
>   ("tests-true: #:tests? #t acceptable for emacs packages")
>   ("tests-true: #:tests? #t acceptable for texlive packages"): New tests.

[...]

> diff --git a/tests/lint.scm b/tests/lint.scm
> index 0f51b9ef79..7b04dc98d4 100644
> --- a/tests/lint.scm
> +++ b/tests/lint.scm
> @@ -35,6 +35,7 @@
>    #:use-module (guix tests http)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
> +  #:use-module (guix build-system emacs)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix packages)
>    #:use-module (guix lint)
> @@ -324,6 +325,25 @@
>                               `(#:tests? ,(not (%current-target-system)))))))
>      (check-tests-true pkg)))
>  
> +;; The emacs-build-system sets #:tests? #f by default.
> +(test-equal "tests-true: #:tests? #t acceptable for emacs packages"
> +  '()
> +  (let ((pkg (dummy-package "x"
> +                            (build-system emacs-build-system)
> +                            (arguments
> +                             `(#:tests? #t)))))
> +    (check-tests-true pkg)))
> +
> +;; Likewise, though the 'check' phase is deleted by default,
> +;; so #:tests? #t won't be useful by itself.
> +(test-equal "tests-true: #:tests? #t acceptable for texlive packages"
> +  '()
> +  (let ((pkg (dummy-package "x"
> +                            (build-system emacs-build-system)
                                             ^ texlive-build-system ? :-)

Thanks!

Maxim