bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50299: [PATCH v3 15/27] gnu: ecl: Don't pretend to enable tests when


From: zimoun
Subject: bug#50299: [PATCH v3 15/27] gnu: ecl: Don't pretend to enable tests when cross-compiling.
Date: Mon, 11 Oct 2021 14:13:19 +0200

Hi Maxime,

I was roaming on this series and the message:

    Don't pretend to enable tests when cross-compiling.

or elsewhere

    Don't run tests when cross-compiling.

appears to me misleading.  I would write:

    Remove unconditional tests.

or something along these lines which is what these commits are doing, IIUC.

On Thu, 30 Sept 2021 at 00:50, Maxime Devos <maximedevos@telenet.be> wrote:

> * gnu/packages/lisp.scm
>   (ecl)[arguments]<#:tests?>: Move comment about failing tests to ...
>   (ecl)[arguments]<#:phases>{check}: ... this deleted phase.
>   (ecl)[arguments]: Remove #:tests? instead of unconditionally setting it to
>   #t.

Thanks for working on that.

Cheers,
simon





reply via email to

[Prev in Thread] Current Thread [Next in Thread]