bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64.

[Maxime Devos]

Liliana Marie Prikler schreef op vr 05-11-2021 om 21:06 [+0100]:
> * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’.
> ---
>  gnu/packages/webkit.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
> index e54b680855..45150e185f 100644
> --- a/gnu/packages/webkit.scm
> +++ b/gnu/packages/webkit.scm
> @@ -295,6 +295,11 @@ (define-public webkitgtk
>                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
>                    (string-append wpebackend-fdo "/lib/" all)))
>                 #t)))
> +         (add-after 'unpack 'disable-sse2
> +           (lambda* (#:key system #:allow-other-keys)
> +             (unless (string-prefix? "x86_64" system)

IIUC, when cross-compiling, you need to look at 'target', not 'system'.
At least, that's the case if %current-system/%current-target-system is
used. Not sure about 'system' and 'target'.

Suggestion:
  (unless ,(target-x86-64?)
    (substitute* ...))

Greetings,
Maxime.