bug#51869: [PATCH] Add emacs-vala-mode

[Liliana Marie Prikler]

Hi,

Am Montag, den 15.11.2021, 20:48 +0000 schrieb Vivien Kraus:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > > Since I don’t have a solution to fix this issue, I went away and
> > > reverted the multiline support. It builds and is useful enough
> > > for LSP to kick in, so I consider it fixed.
> > > 
> > > What do you think? Do you have a better fix?
> > Given my superior knowledge of Emacs Lisp (just kidding), I'd guess
> > the order of declarations is wrong.  Pull the defcustom before the
> > other thing and it ought to work.
> Unfortunately, it does not. I tried it, but it gives the same error
> message. I’m a bit surprised, but reading the help entry for
> c-lang-defconst, I see there is a lot of information about when
> things are evaluated, so maybe someone smart can parse it and
> understand why we can’t use the custom variable value.
I investigated further and the thing at hand (multiline string support)
is currently buggy in CC-Mode anyway.  There are plans to support all
kinds of multiline strings with a new API in an upcoming version,
however vala-mode is not yet written with that in mind.  Given this
knowledge, I'd second your decision to disable multiline strings for
now.

> > > +   (version "20201218.2109")
> > > +   (source
> > > +    (origin
> > > +      (method git-fetch)
> > > +      (uri (git-reference
> > > +            (url "https://github.com/rrthomas/vala-mode.git";)
> > > +            (commit
> > > "d696a8177e94c81ea557ad364a3b3dcc3abbc50f")))
> > Use the (let ((revision ...) (commit ...)) (package ...))
> > convention,
> > adding a note that upstream has no tagged release.  Base version
> > appears to be "0.1"
> I didn’t know that convention, so here is the updated patch, still
> waiting for a convincing fix for the multiline strings issue.
I'd use our emacs sexp substitution tools to erase these defconsts and
defcustoms rather than a patch.  Other than that LGTM.

Cheers