[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51801: closed (Re: bug#51801: No warning when attempting to build un
From: |
Maxim Cournoyer |
Subject: |
bug#51801: closed (Re: bug#51801: No warning when attempting to build unsupported system with --system) |
Date: |
Sat, 19 Feb 2022 21:46:13 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Ludo,
> From: Ludovic Courtès <ludo@gnu.org>
> Subject: Re: bug#51801: No warning when attempting to build unsupported
> system with --system
> To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Cc: 51801-done@debbugs.gnu.org
> Date: Fri, 18 Feb 2022 14:18:02 +0100 (1 day, 13 hours, 27 minutes ago)
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> I was surprised that:
>>>
>>> guix build fpc --system=armhf-linux
>>>
>>> would send me in a dead end without any word of caution, given that
>>> armhf-linux is *not* listed in the supported-systems field.
>>>
>>> We should at least warn near the beginning of the build, and remind of
>>> that fact at the end of the build in case of failure.
>>
>> I came up with the patches below.
>>
>> The first part forbids unsupported packages altogether in user-facing
>> commands: ‘guix install’, ‘guix shell’, etc. Until now, they’d just
>> start building things that were bound to fail.
>>
>> The second part adds a mere warning for ‘guix build’ (it does not repeat
>> it at the end, though).
>
> I went ahead and pushed them:
>
> 0ca26437cb guix build: Warn when attempting to build an unsupported package.
> 5a57313918 profiles: 'profile-derivation' rejects unsupported packages.
> 0572737a62 packages: 'package-transitive-supported-systems' ignores
> '%current-target-system'.
Thank you!
Maxim