[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22608: Module system thread unsafety and .go compilation
From: |
Maxim Cournoyer |
Subject: |
bug#22608: Module system thread unsafety and .go compilation |
Date: |
Fri, 07 Oct 2022 20:21:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
ludo@gnu.org (Ludovic Courtès) writes:
> Hello,
>
> taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:
>
>> To speed up the compilation of the many Scheme files in Guix, we use a
>> script that first loads all modules to be compiled into the Guile
>> process (by calling 'resolve-interface' on the module names), and then
>> the corresponding Scheme files are compiled in a par-for-each.
>>
>> While Guile's module system is known to be thread unsafe, the idea was
>> that all mutation should happen in the serial loading phase, and the
>> parallel compile-file calls should then be thread safe.
>>
>> Sadly that assumption isn't met when autoloads are involved.
>
> For the record, these issues should be fixed in Guile 2.2.4:
>
> 533e3ff17 * Serialize accesses to submodule hash tables.
> 46bcbfa56 * Module import obarrays are accessed in a critical section.
> 761cf0fb8 * Make module autoloading thread-safe.
>
> ‘guix pull’ now defaults to 2.2.4, so we’ll see if indeed those crashes
> disappear.
I think we haven't seen these in the last 4 years! We still have
references to https://bugs.gnu.org/15602 in our code base though;
although the upstream issue appears to have been fixed. Could we remove
the workarounds now?
--
Thanks,
Maxim
- bug#22608: Module system thread unsafety and .go compilation,
Maxim Cournoyer <=