bug#59131: gnu: emacs-magit: Tests fail.

[Kyle Meyer]

paren--- via Bug reports for GNU Guix writes:

>   $ guix describe
>   Generation 240      Nov 08 2022 18:38:30    (current)
>   guix c52cdd1
>     repository URL: https://git.savannah.gnu.org/git/guix.git
>     branch: master
>     commit: c52cdd18d6f8dddd69dfb1f8b5214a0db6ebb562
> [...]
>
>   2 unexpected results:
>      FAILED  magit-get
>      FAILED  magit-toplevel:submodule
>
>   1 skipped results:
>     SKIPPED  magit-toplevel:tramp
>
>   make: *** [Makefile:111: test] Error 1
>
> This appears to have been caused by commit 83ede5a ("gnu: git: Update to 
> 2.38.1.").

Thanks for posting this.  This recently started failing on Magit's CI,
but nobody had looked into it too deeply yet.  Your message suggested
that bisecting Git v2.38.0..v2.38.1 would be a good place to start.

That pointed to this being fallout from Git's a1d4f67c12 (transport:
make `protocol.file.allow` be "user" by default, 2022-10-01), and the
two failures above are now resolved by Magit's 36059e0b (test: Set
protocol.file.allow=always to restore old Git behavior, 2022-11-08).

(In terms of fixing Guix's emacs-magit build, 36059e0b applies cleanly
to v3.3.0's tree.)