[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32026: [PATCH v4 3/9] gnu: Define %icecat-base-version at the top le
From: |
Maxim Cournoyer |
Subject: |
bug#32026: [PATCH v4 3/9] gnu: Define %icecat-base-version at the top level. |
Date: |
Sun, 19 Feb 2023 17:14:29 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Mark,
Mark H Weaver <mhw@netris.org> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>> * gnu/packages/gnuzilla.scm (%icecat-base-version): New variable.
>> (%icecat-version): Define in terms of %icecat-base-version.
>> (icecat-source): Adjust to use the above newly introduced variables.
>
> What's the rationale for this? I couldn't find any uses of
> '%icecat-base-version' in your patch set outside of 'icecat-source'.
> I don't have a strong objection, but it seems unjustified.
>
> Thanks,
> Mark
Not much anymore, but I just thought it was cleaner than having to do
(base-version (first (string-split %icecat-version #\-))) later on to
retrieve this information.
--
Thanks,
Maxim
- bug#32026: [PATCH v4 1/9] gnu: Add a 'update-mozilla-locales' helper for maintenance., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 2/9] gnu: icedove: Compute a self-contained source., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 3/9] gnu: Define %icecat-base-version at the top level., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 9/9] gnu: icecat: Unbundle nss and nspr., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 8/9] gnu: icecat: Remove gtk+-2 input., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 4/9] gnu: Add icecat-l10n and icedove-l10n., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 6/9] gnu: Add language packs to icecat and icedove., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 5/9] gnu: icedove: Automatically load system-provided extensions., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 7/9] gnu: icedove: Use the locale of the system., Maxim Cournoyer, 2023/02/19
- bug#32026: [PATCH v4 1/9] gnu: Add a 'update-mozilla-locales' helper for maintenance., Mark H Weaver, 2023/02/19
- bug#32026: [PATCH v4 1/9] gnu: Add a 'update-mozilla-locales' helper for maintenance., Ludovic Courtès, 2023/02/20