[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gv] Working around gs issues by changing to a safe working dir
From: |
Markus Steinborn |
Subject: |
Re: [bug-gv] Working around gs issues by changing to a safe working dir |
Date: |
Thu, 03 Jun 2010 14:19:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.9) Gecko/20100317 SeaMonkey/2.0.4 |
Bernhard R. Link schrieb:
* Markus Steinborn<address@hidden> [100602 17:14]:
- create the directory on install time
done
+ -mkdir "$(DESTDIR)$(pkgdatadir)/safe-gs-workdir"
please use mkdir -p instead of -mkdir. (for example via $(MKDIR_P))
Ignoring errors is not that nice and when using DESTDIR the next
command can fail because nothing garantees $(DESTDIR)$(pkgdatadir)
already exists, so the mkdir could not create the subdirectory.
Well, GNU coding standard says:
"Generally, stick to the widely-supported (usually
posix-specified) options and features of these programs. For
example, don't use mkdir -p, convenient as it may be, because a
few systems don't support it at all and with others, it is not safe
for parallel execution. For a list of known incompatibilities, see
Portable Shell, Portable Shell Programming,, autoconf, Autoconf."
So we need a different alternative.
Greetings
Markus