Re: Gzip testsuite uses system-installed gzip?

[Paul Eggert]

Chris Staub <address@hidden> writes:

> I was looking at the gzip testsuite (gzip 1.3.12) and it uses the
> currently-installed gzip program to compress a file, then uses zdiff
> on the file. Considering that it seems odd to use a system-installed
> program for testing

Thanks for catching that.  I installed this patch:

2007-10-04  Paul Eggert  <address@hidden>

        * Makefile.am (gzip.doc.gz, check-local): Depend on $(bin_PROGRAMS).
        (gzip.doc.gz): Use our gzip, not the system-installed one.
        Problem reported by Chris Staub in
        <http://lists.gnu.org/archive/html/bug-gzip/2007-10/msg00000.html>.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/gzip/gzip/Makefile.am,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile.am
--- Makefile.am 3 Jul 2007 20:37:07 -0000       1.23
+++ Makefile.am 4 Oct 2007 22:25:04 -0000
@@ -49,8 +49,8 @@ gzip_LDADD = lib/libgzip.a
 gzip.doc: gzip.1
        groff -man -Tascii $(srcdir)/gzip.1 | col -b | uniq >$@

-gzip.doc.gz: gzip.doc
-       gzip <$? >$@
+gzip.doc.gz: gzip.doc $(bin_PROGRAMS)
+       ./gzip <gzip.doc >$@

 SUFFIXES = .in
 .in:
@@ -64,7 +64,7 @@ SUFFIXES = .in
 # A simple test, just of gzip -- more of a sanity check than anything else.
 FILES_TO_CHECK = $(bin_SCRIPTS) $(gzip_LDADD) \
   $(top_srcdir)/ChangeLog $(top_srcdir)/configure $(top_srcdir)/gzip.c
-check-local: $(FILES_TO_CHECK) gzip.doc.gz
+check-local: $(FILES_TO_CHECK) $(bin_PROGRAMS) gzip.doc.gz
        { test '$(srcdir)' != . || ./zdiff --__bindir . -c gzip.doc.gz; }
        ./zdiff --__bindir . -c $(srcdir)/gzip.doc $(srcdir)/gzip.doc
        ./zdiff --__bindir . $(srcdir)/gzip.doc gzip.doc.gz