[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-

From: Paul Eggert
Subject: Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length
Date: Tue, 29 Nov 2011 13:54:33 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 11/29/11 13:38, Jim Meyering wrote:

> -#define TYPE_IS_INTEGER(t) ((t) 1.5 == 1)
> +#define TYPE_IS_INTEGER(t) ((t) 1.5F == 1)

I'd rather omit this.  The constant is represented exactly and is an
immediate operand of a cast.  (And I wouldn't be surprised if some
compilers warned about the "F" for that reason....)  If GCC is warning
about this, that's more of a GCC bug than anything else.

I second Eric's other comments about the changes.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]