Re: yet another hello pretest

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> Jim Meyering wrote:
>> Better still, add this in system.h:
>>
>>     #if ! ENABLE_NLS
>>     # undef textdomain
>>     # define textdomain(Domainname) /* empty */
>>     # undef bindtextdomain
>>     # define bindtextdomain(Domainname, Dirname) /* empty */
>>     #endif
>
> If you do this, you'll get "unused variable" warnings when you use
> textdomain or bindtextdomain with non-literal arguments. It might work
> in your system.h, but is IMO not suitable for general use in gettext.h.

Hi Bruno,

You seem to have misunderstood.  It sounds like you're objecting to
something, but I didn't propose to put it in *gettext.h*.  I don't see
how you could be objecting to such an addition to hello's system.h.
If someone is doing something fancy, they can be expected to find their
own solution.

GNU hello is about demonstrating what works for most packages.
The above works for all 90+ programs in the coreutils package,
as well as for many other GNU tools.