[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] use gnulib to print --help and --version
From: |
Reuben Thomas |
Subject: |
Re: [PATCH 3/7] use gnulib to print --help and --version |
Date: |
Tue, 31 Dec 2013 19:57:20 +0000 |
Fine, except for the following minor things.
On 30 December 2013 11:58, Sami Kerola <address@hidden> wrote:
> diff --git a/src/hello.c b/src/hello.c
> index fe85539..90b1c08 100644
> --- a/src/hello.c
> +++ b/src/hello.c
> @@ -19,25 +19,32 @@
> #include <config.h>
> #include "system.h"
> #include "progname.h"
> +#include "progname.h"
> +#include "propername.h"
> #include "xalloc.h"
>
You end up with two includes of progname.h here!
> +/* The official name of this program (e.g., no `g' prefix). */
> +#define PROGRAM_NAME "hello"
>
Since in our case it's the same as the package name, can't you use that
here, and avoid duplicating the string "hello"?
> +#define AUTHORS \
> + proper_name ("The King"), \
> + proper_name ("others")
>
This looks bizarre. Is "The King" a known joke in hello? I can only find
the reference in AUTHORS. If we can find a better original author, can we
use that, and if not, maybe just leave AUTHORS blank (however best one does
that)?
--
http://rrt.sc3d.org
[PATCH 5/7] demonstrate how to add information to a manual page, Sami Kerola, 2013/12/30
[PATCH 4/7] use standard error printing facilities, Sami Kerola, 2013/12/30
[PATCH 7/7] update NLS file sources, Sami Kerola, 2013/12/30