Re: [PATCH 3/7] use gnulib to print --help and --version

[Reuben Thomas]

On 11 January 2014 11:38, Sami Kerola <address@hidden> wrote:

> On 31 December 2013 23:49, Karl Berry <address@hidden> wrote:
> >     >> +#define PROGRAM_NAME "hello"
> >     >
> >     > Since in our case it's the same as the package name, can't you use
> that
> >     > here, and avoid duplicating the string "hello"?
> >
> >     I have feeling that might give wrong impression as an example.
> >
> > Anything in GNU hello is being implicitly recommended for general use.
> > Normally, GNU packages have no need to deal with a special g-prefix.
> > Therefore IMHO it is (much) better to omit the redundancy.
>
> Maybe the question is if the use of gnulib module version-etc-fsf
> should be recommended or not. If yes AUTHOR and PROGRAM_NAME are
> unavoidable. I am in favor recommending unified look & style of --help
> and --version outputs across commands, what this module tries to do.
>

Two points:

1. The only real problem was the duplication of the string "hello", not the
use of PROGRAM_NAME. But given the progname module, which copes with the
program being installed under different names, I don't see the need for a
different way to get the name.

2. I don't see anything about AUTHOR or PROGRAM_NAME in version-etc{,-fsf}.
version-etc indeed has an array of AUTHORS, while the version_etc*
functions seem to take command_name and package arguments, which can come
presumably from program_name and PACKAGE_NAME, or whichever
autoconf-supplied macro is suitable, respectively.


>
> --
> Sami Kerola
> http://www.iki.fi/kerolasa/
>



-- 
http://rrt.sc3d.org