Re: PPP port: iface_Create

[Marcus Brinkmann]

On Sat, Dec 02, 2000 at 06:56:10PM -0600, Daniel E Baumann wrote:
> > >   ioctl(s, SIOCGIFFLAGS, &ifr);
> >
> > We have this, but ifr isn't initialized yet! You need to set the name.
> > Also, the second argument is a struct ifreq **, while you need a struct
> > ifreq *. But if you change ifr as above, the code gets correct again :)
> 
> So before I use an ifreq I have to set its name. What do you mean the second 
> argument is a struct ifreq **, I thought it was "int request" like the man 
> page and header flie says?

Make that "third arg", sorry. Anyway, if you make ifr a struct rather than
a pointer, as it was, it's fine.
 
> I am also considering factoring this code into a separate file as this part 
> will be permanent changes as the glibc functionality is/will be there, the 
> rest of the changes I am leaving as #ifdef'd. I'll probably talk to the 
> maintainer and see if he's happy with my changes and if he'll incorporate 
> them upstream.

Mmmh. I am rather unhappy with the Hurd pfinet interface currently. I would
like to have at least interface addresses and some primitive routing
interface. But of course if you think it is feasible to have the patches
incorporated at this stage of Hurd development even, that would be cool.

> Also, I hasve been using Debian for quite a while and  would 
> like to learn how to make a deb package. Do you think it would be useful to 
> make a deb of ppp when it's done?

Definitely!

> I know that you Marcus, probably could do 
> this with no problem, but I'd like to learn how to make one. I have a 
> SourceForge account to if that helps any, my user name is baumannd.

If you want to upload this into the Debian archive (and you should), you
should apply to become a regular Debian maintainer (the Debian pages will
tell you how). I can sponsor you initially (take what you did and upload
it), but that's not a replacement for being a Debian member yourself.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de