[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libdiskfs/io-revoke.c

From: Roland McGrath
Subject: Re: libdiskfs/io-revoke.c
Date: Sun, 1 Apr 2001 17:41:37 -0400 (EDT)

> In io-revoke.c, we iterate over the protid class yet we inhibit
> all RPCs on the bucket.  Why do we not just inhibit the class?

Inhibiting the bucket also prevents any other RPCs that might result in
creating a protid.  Inhibiting the protid class would prevents RPCs made on
protid ports, but would not prevent RPCs on the fsys control port that
could create new protid ports.  We could use ports_count_class on
diskfs_protid_class to block new creations, followed by ports_inhibit_class
to block RPCs, but that is more overhead than just blocking the whole
bucket.  The only things that are unnecessarily blocked by doing this are
fsys_* calls other than fsys_getroot (which would do protid creation and be
blocked there).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]