[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libdiskfs: bugs

From: Roland McGrath
Subject: Re: [PATCH] libdiskfs: bugs
Date: Sun, 15 Apr 2001 18:43:17 -0400 (EDT)

>       * dir-chg.c (disk_S_dir_notice_changes): Check the return of malloc.

Your actual patch removes the check that was already there.

>       * file-set-trans.c (diskfs_S_file_set_translator): Be
>       consistent, use err not error.

Please do not make this sort of gratuitous change.  There is no compelling
reason that a local variable has to have one name or another, and I don't
like polluting the revision history with unnecessary cosmetic changes.

>       * init-init.c (_diskfs_control_clean): Spit out a warning if
>       there are no outstanding send rights to our control port.

This is not appropriate.  There is nothing wrong with the number of live
control ports going to zero.  

I've applied the other (two) changes.  Only the node-create.c change was a
bug fix.  It would be ideal if you could separate bug fixes from other
changes that do not affect the behavior.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]