bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug#102437: dealloc analysis for each server function, more bugs!


From: Marcus Brinkmann
Subject: Bug#102437: dealloc analysis for each server function, more bugs!
Date: Wed, 11 Jul 2001 00:18:32 +0200
User-agent: Mutt/1.3.18i

On Sat, Jun 30, 2001 at 08:54:12PM -0700, Thomas Bushnell, BSG wrote:
> Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de> writes:
> 
> > I would suggest dealloc + iohelp_return_malloced_buffer, as usually those
> > uid vectors are small, and keeping them on one page each is a waste of
> > space.
> 
> iohelp_return_malloced_buffer is not available in auth, nor should it
> be.... just duplicated its functionality perhaps.  it's not that
> complex.

Right.  We can't use it anyway, as it will free the buffer.  Duplicating the
functionality is the thing to do (we do it in a lot of places).
 
> I haven't reviewed your logic tho; I'll think about that later.

I committed my changes for the other interfaces, which just require the
dealloc parameter.  For the auth server, I will send a patch for review
soon.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de




reply via email to

[Prev in Thread] Current Thread [Next in Thread]