[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
ihash_add
From: |
Marcus Brinkmann |
Subject: |
ihash_add |
Date: |
Mon, 20 Aug 2001 16:13:25 +0200 |
User-agent: |
Mutt/1.3.18i |
Hi,
why does the initial loop in ihash_add not break out on
ht->ids[h] == id? It seems that this is a condition that is
checked in the following code, but that can only happen if
h == firsth, and this means that the hash table is full and
the element with this id was hashed with its first hash value at some time.
So I think, that's a bug. If you agree, I would like to fix it and rewrite
the loop a bit (initialize h and firsth to HASH(ht, id), and replace
the for with a simple while loop). Also using index_empty.
I think it is unnecessary convoluted right now.
Thanks,
Marcus
- ihash_add,
Marcus Brinkmann <=