Re: Malloc patches, round 1 (reseting round count)

[Igor Khavkine]

On Sun, Sep 09, 2001 at 07:32:34PM +0200, Marcus Brinkmann wrote:
> On Wed, Aug 01, 2001 at 02:39:53AM -0400, Igor Khavkine wrote:
> > I've looked through the comments to my eariler posts, and I've
> > made appropriate changes. Even the formatting. :-)
> 
> Hi,
> 
> I had started to work in the patches, but it is a lot of work :-/
> The reason is that I had to change all of the changes I looked at so far,
> there were just too many little buglets.
> 
> Here is an idea of the bugs I found:
> 
> * Wrong check if asprintf() fails (same I noticed in the 3rd patch, too).
> * Not freeing the allocated resources when bailing out (like, iouser when
>   netfs_make_protid fails).
> * Setting err to errno after making other library calls (which don't give
>   any guarantee about stability of errno).
> 
> I did not look at all patches, I just started incorporating and found all of
> these several times (IIRC).  I checked in my changes to libnetfs as far as I
> came.  You might want to go over your patches one more time.  

Hmm, this is sort of ironic because this is exactly the kind of bugs I was
trying to fix. :-) Ok, I'll look over the patches again. But probably
not right away. I've just started school and I'm not sure how much time
I'll be able to devote to Hurd hacking this semester.

Igor