[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: oskit-mach & oskit-20010214: network

From: Roland McGrath
Subject: Re: oskit-mach & oskit-20010214: network
Date: Sun, 23 Sep 2001 13:58:55 -0400 (EDT)

First, a trivial thing (typo): Your softclock_oskit code calls
base_irq_softint_enabled where you want base_irq_softint_enable.

I haven't thought through in full detail what your code does.  But I think
it is dubious in fundamental ways.  I don't understand the rationale behind
using base_irq_soft* and diddling with osenv_intr_*.

The osenv_softirq should be implemented entirely in terms of the Mach spl*
calls.  i.e., disable = splsoftclock, enable = splx(what it was before),
and for schedule just call setsoftclock after setting your mask (at

reply via email to

[Prev in Thread] Current Thread [Next in Thread]