[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] bug in libstore/std.c
|
From: |
Marcus Brinkmann |
|
Subject: |
Re: [patch] bug in libstore/std.c |
|
Date: |
Wed, 10 Oct 2001 20:29:18 +0200 |
|
User-agent: |
Mutt/1.3.22i |
On Wed, Oct 10, 2001 at 01:01:24AM -0500, Kevin Kreamer wrote:
> Neal and I found a bug in libstore/std.c where &store_part_class was
> not compiled in due to HAVE_PARTED_PARTED_H not being defined. Neal's
> suggested fix was to change it to HAVE_LIBPARTED, which is the included
> patch.
Yeah, but including a header file should depend on the header file check,
not on the library check. I suggest this:
--- configure.in Wed Oct 10 20:25:07 2001
+++ /mnt/marcus/gnu/cvs/hurd/configure.in Wed Aug 29 14:00:52 2001
@@ -128,7 +128,7 @@
save_LIBS=
LIBS=
test $parted = no || {
- AC_CHECK_HEADER(parted/parted.h, [AC_DEFINE(HAVE_PARTED_PARTED_H)],
parted=no)
+ AC_CHECK_HEADER(parted/parted.h, , parted=no)
}
test $parted = no || {
AC_CHECK_LIB(uuid, uuid_generate, , parted=no)
The trick is that the "true" case is now handled as in the standard autoconf
check. Does this work for you?
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann GNU http://www.gnu.org marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de