bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH]: don't test the OSENV_NONBLOCKING flag


From: Daniel Wagner
Subject: [PATCH]: don't test the OSENV_NONBLOCKING flag
Date: Sun, 28 Oct 2001 12:22:24 +0100
User-agent: Mutt/1.2.5i

Hi

The following patch dissables a test on the OSENV_NONBLOCKING flag.
This is needed because there is a discrepancy between the oskit
docs and the code. Though the docs says it is set, it is not. This
prevents oskit-mach from correct working. 

wagi



2001-10-28  Daniel Wagner <wagi@gmx.ch>

        * oskit/osenv_mem.c (alloc_for_oskit, free_for_oskit): Don't test 
        the OSENV_NONBLOCKING flag. The flag is not set, though it is 
        mention in the oskit documentation (Version 0.97-20010214).




Index: osenv_mem.c
===================================================================
RCS file: /cvsroot/hurd/gnumach/oskit/Attic/osenv_mem.c,v
retrieving revision 1.1.2.6
diff -c -p -r1.1.2.6 osenv_mem.c
*** osenv_mem.c 2000/10/28 02:27:06     1.1.2.6
--- osenv_mem.c 2001/10/28 11:06:30
*************** alloc_for_oskit (oskit_size_t size, osen
*** 101,109 ****
--- 101,113 ----
         Always go directly to physical memory.  */
      flags |= OSENV_VIRT_EQ_PHYS|OSENV_PHYS_WIRED|OSENV_PHYS_CONTIG;
  
+ /* XXX The version of oskit we are working with (20010214) does not
+    seem to respect this requirement */
+ #if 0
    if (in_oskit_interrupt)
      /* The oskit documentation says an interrupt caller must set the
 * flag.  */
      assert (flags & OSENV_NONBLOCKING);
+ #endif
  
    if (!(flags & (OSENV_NONBLOCKING|OSENV_PHYS_WIRED)))
      {
*************** free_for_oskit (void *block, osenv_memfl
*** 194,202 ****
--- 198,210 ----
         Always go directly to physical memory.  */
      flags |= OSENV_VIRT_EQ_PHYS|OSENV_PHYS_WIRED|OSENV_PHYS_CONTIG;
  
+ /* XXX The version of oskit we are working with (20010214) does not
+    seem to respect this requirement */
+ #if 0
    if (in_oskit_interrupt)
      /* The oskit documentation says an interrupt caller must set the
 * flag.  */
      assert (flags & OSENV_NONBLOCKING);
+ #endif 
  
    if ((oskit_addr_t) block < phys_mem_max)
      {


-- 
Daniel Wagner                              "use quit to exit"
email: wagi@gmx.ch

GnuPG: 1024D/DCDE890A (public key available on any keyserver)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]