Re: term & user space console

[Marcus Brinkmann]

On Sat, Feb 02, 2002 at 07:53:12PM -0500, Roland McGrath wrote:
> >       /* Mach forces us to use the normal stop bit convention:
> >          two bits at 110 bps; 1 bit otherwise. */
> 
> Ah, that stuff is just coping with the crappiness of the Mach device code.
> You can just pass down the CSTOPB/CSIZE bits directly to the underlying tty.

Ok, thanks.
 
> > So far I got it, I am just worried about stuff like the above, where I don't
> > know if it is something idiosyncratic to Mach devices, or generic.
> 
> You can consider anything in devio.c likely to be idiosyncratic to Mach
> devices (and not just the supposed interfaces, but the broken drivers we
> have at that).  But I don't see any other code of that nature beside that
> one spot you cited.

Mmmh.  The last piece I have here is in desert_dtr:

  /* Turn off DTR. */
  bits = TM_HUP;
  device_set_status (phys_device, TTY_MODEM,
                     (dev_status_t) &bits, TTY_MODEM_COUNT);

I guess this is taken care of entirely by my implementation, that just
closes the ioport:

  if (ioport)
    {
      mach_port_deallocate (ioport);
      ioport = MACH_PORT_NULL;
      hurd_thread_cancel (writer_thread);
      hurd_thread_cancel (reader_thread);
    }

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de