Re: the big term patch

[Thomas Bushnell, BSG]

Roland McGrath <roland@gnu.org> writes:

> This stuff all looks great.  As usual, Marcus, you rule.

I was gonna say he rocks.

> In general, we should check for anything like this in the code.  For
> anything that can have an error, the global state should not be
> tweaked before the bottomhalf call is attempted, and the bottomhalf
> call should have an argument for the new state being put in.  

Yes, this is a bug in my original architecture for the program.  I
agree with this general strategy for fixing it.

> Only in the call succeeds should term's state variables be updated.

I'm inclined to think that it should specifically be the bottom half's
responsibility for updating the state variables.  That way the Right
Thing can be done if some but not all of the changes can be made.

> If you are on random feature patrol, seems like we might as well give term
> the --readonly/--writeonly options (and --writable and all aliases)
> streamio has.  I don't know why you'd want to use them in term, but then I
> don't know off hand why you'd want them in streamio either. :)
> I guess we might as well have --rdev too.

Ditto.