Re: roland_libstore_modules_branch

[Marcus Brinkmann]

On Tue, Mar 05, 2002 at 04:26:52PM -0500, Roland McGrath wrote:
> Has anyone tried this code at all?

Ok, I bite.  First, it compiles and builds.  The statically compiled ext2fs
contains the following store classes (don't mind the date in the path, the
directory has the latest CVS code of today):

marcus@stampede:~/merry/hurd/hurd-20020103/build/ext2fs$ objdump --syms 
ext2fs.static|grep store_std_classes
080fd9a0 l    d  store_std_classes      00000000
080fd9a0 l     O store_std_classes      00000004 store_std_classes_query
080fd9a4 l     O store_std_classes      00000004 store_std_classes_ileave
080fd9a8 l     O store_std_classes      00000004 store_std_classes_concat
080fd9ac l     O store_std_classes      00000004 store_std_classes_remap
080fd9b0 l     O store_std_classes      00000004 store_std_classes_file
080fd9b4 l     O store_std_classes      00000004 store_std_classes_typed_open
080fd9b8 l     O store_std_classes      00000004 store_std_classes_url_open
080fd9bc l     O store_std_classes      00000004 store_std_classes_unknown
080fd9a0 g     O *ABS*  00000000 __start_store_std_classes
080fd9c0 g     O *ABS*  00000000 __stop_store_std_classes

With the fixes I checked in, the following for example works:
settrans -ac testimg.node ./ext2fs.static -T concat @file:testimg1@file:testimg2

Where testimg1 and testimg2 are the two parts of a full filesystem image.
marcus@stampede:~/merry/hurd/hurd-20020103/build/ext2fs$ storeinfo testimg.node
remap (enf;0x200): -: 1: 1024: 1024: 21504+1024
  concat (enf): +file:testimg1+file:testimg2: 1: 1048576: 1048576: 
0+524288,0+524288
    file (enf): testimg1: 1: 524288: 524288: 0+524288
    file (enf): testimg2: 1: 524288: 524288: 0+524288

The gunzip store is not recognized (as expected):
marcus@stampede:~/merry/hurd/hurd-20020103/build/ext2fs$ settrans -ac 
testimg.node ./ext2fs.static -T gunzip testimg.gz
ext2fs.static: gunzip: Invalid argument to --store-type
Try `ext2fs.static --help' or `ext2fs.static --usage' for more information.
settrans: ./ext2fs.static: Translator died

Now shared library.  The following works:
settrans -ac testimg.node  ./ext2fs -T file testimg'

Concat store does also work:
marcus@stampede:~/merry/hurd/hurd-20020103/build/ext2fs$ settrans -ac 
testimg.node /bin/sh -c 'export LD_LIBRARY_PATH=../libstore; ./ext2fs -T concat 
@file:testimg1@file:testimg2'

The gunzip store is recognized, but I get an EIO error (I get this error
with the old code, too, so I don't show it here).

storeio works, too.

What does not work is a statically linked storeio.  It doesn't parse its
argument!  argp calls the parsers with the ARGP_KEY_INIT (or whatever it was
called), but does not parse any of the options on the command line.  Thus
there is still some glitch.  I did test a storeio.static with the old code,
and it worked.  So there is something funny going on.

I did only the above tests, not a full install and boot, which one should
probably do next.  But it already looks very promising, fine work!

Thanks,
Marcus


-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de