Re: zealous use of error

[Thomas Bushnell, BSG]

James A Morrison <ja2morri@student.math.uwaterloo.ca> writes:

> libnetfs:
>       * make-protid.c (netfs_make_protid): Use err, not errno.

This one is incorrect; it changes the established interface of
netfs_make_protid, which is that errno is set on error returns.

See, for example, libnetfs/fsys-getroot.c which depends on this
behavior.

(There are other callers of netfs_make_protid which do not properly
check for errors, but should.  They would also depend on this
behavior.)


Thomas