[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: diskfs_make_node returns an error_t

From: James Morrison
Subject: Re: patch: diskfs_make_node returns an error_t
Date: Tue, 2 Apr 2002 15:32:59 -0800 (PST)

--- Roland McGrath <roland@gnu.org> wrote:
> I don't see anything wrong with the current diskfs_make_node signature.
> It can only return failure for a malloc failure. 

 The advantages I see of using a signature that returns an error are:

1. Any users of make_node, this applies to both netfs_ and diskfs_, don't need
know what error has occured, just that one has occurred.

2. This signature is more consistent with the other functions in libnetfs and
libdiskfs such as make_peropen and make_protid.

James Morrison
   University of Waterloo
   Computer Science - Digital Hardware
   2A co-op

Anyone refering this as 'Open Source' shall be eaten by a GNU

Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax

reply via email to

[Prev in Thread] Current Thread [Next in Thread]