bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pflocal/sock.c


From: Marcus Brinkmann
Subject: Re: [PATCH] pflocal/sock.c
Date: Wed, 24 Apr 2002 18:23:24 +0200
User-agent: Mutt/1.3.28i

On Wed, Apr 24, 2002 at 06:36:19PM +0300, Ognyan Kulev wrote:
> `pflocal/sock.c:sock_shutdown' can be called with both flags 
> SHUTDOWN_READ and SHUTDOWN_WRITE set (according to 
> `pflocal/socket.c:S_socket_shutdown').  When this happen the 
> `sock->lock' mutex is unlocked before calling `pipe_remove_reader' but 
> the next `if' statement (that checks for SHUTDOWN_WRITE) assumes that 
> `sock->lock' is locked.  Is this a problem?

Yes, of course, the code was obviously wrong, and I think your fix is right. 
I tested it and checked it in.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de



reply via email to

[Prev in Thread] Current Thread [Next in Thread]