Re: diskfs_make_node

[Marcus Brinkmann]

On Sat, Nov 17, 2001 at 12:15:00AM +0100, Neal H Walfield wrote:
> > Those void functions you changed to error_t can never fail, so I don't see
> > the point.  The actual diskfs_make_node changes seem ok.
> 
> They can never fail today, however, I thought it made the interface a
> bit more consistent.  I guess, however, you are right, there is no
> need.
> 
> Here is revised patch:
> 
> libdiskfs:
> 
> 2001-11-16  Neal H Walfield  <neal@cs.uml.edu>
> 
>         * diskfs.h (diskfs_make_node): Change the prototype.  The node
>         is now returned in a local argument and the function itself
>         returns an error_t.
>         * node-make.c (diskfs_make_node): Up date to new semantics.
>         Do more through error checking.

etcetc

You are leaking the DN disknode in the ext2fs and ufs case, please free(dn)
it.  Also, please change the doc/hurd.texi (I know it's only patchwork, but
there is no reason to let it get out of sync even more if it is easy to
fix).  With those changes, I think you can check it in.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de