Re: it's make's fault (was: Re: fakeroot status (an ongoing story :)

[Marcus Brinkmann]

On Sun, May 26, 2002 at 04:16:27AM +0200, Marcus Brinkmann wrote:
> $ ls /dev/fd
> Segmentation fault

Ok, this was easily fixed by correcting an off-by-one error in magic:

2002-05-26  Marcus Brinkmann  <marcus@gnu.org>

        * magic.c (trivfs_S_dir_readdir): Increment I after comparing it
        with ENTRY, to fix off-by-one error.

fakeroot works fine now.  I got one spurious perl error when building the
hello package (I built the same package four times, and one time it failed),
so there might still be some race condition or buglet here and there, but with
all the latest fixes it should be ready for public consumption, and maybe
someone else can have a crack at any remaining problems.

So, basic functionality is there, stress testing needs to be done still.

I am not sure if the client side is all proper, though.  The magic server
returned 0 nentries, data and datalen pointing to one dir entry.  I have
forgotten how the code flow exactly was on the client side, but it seemed
to mess things up quite a bit.  I might have another look now that fakeroot
works.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de