Re: console-ncurses segv

[David Walter]

Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de> writes:

> On Mon, Aug 26, 2002 at 01:16:36PM -0400, David Walter wrote:
>> I think I have exposed  some minor bug  though, I notice that the text
>> client for xemacs moves the cursor  one character forward when it does
>> a  display-time update, but  this doesn't seem  to happen when running
>> under a normal console, so I  don't know if this  is an xemacs problem
>> or the console client problem.
>
> Do you still see this with the new version?  I have fixed a couple of bugs,
> and the other bug I told you about, the artifacts in "lynx
> www.slashdot.org", is now mostly gone.  What is still corrupt is probably
> due to the &middot; (bullet) displayed by lynx is not correctly displayed by
> ncurses.  I have not looked further into this yet.
>
> I don't see any display bugs in my VGA client anymore, but it doesn't have a
> lot of testing yet.

I don't know about the  lynx www.slashdot.org problem,  I don't see it
with the current version, but I  don't know if I  saw it previously (I
hadn't been to  slashdot with  lynx  in the console-ncurses). But  the
following fixes couple of things, if cons_init fails, it cleans up the
console, and  this seems to correctly restore   the cursor location in
emacs  and in the irc  client that I  am using scrollz, which are both
still  repeatable for me  with  the latest  cvs versions  of console &
libcons.

Index: console-ncurses.c
===================================================================
RCS file: /cvsroot/hurd/hurd/utils/console-ncurses.c,v
retrieving revision 1.1
diff --unified -w -i -r1.1 console-ncurses.c
--- console-ncurses.c   22 Aug 2002 21:33:02 -0000      1.1
+++ console-ncurses.c   29 Aug 2002 04:18:24 -0000
@@ -518,9 +621,9 @@
     return;
 
   mutex_lock (&ncurses_lock);
-  getsyx (y, x);
+   getyx (stdscr, y, x);
   mvwputsn (str, length, col, row);
-  setsyx (y, x);
+   wmove (stdscr, y, x);
   mutex_unlock (&ncurses_lock);
 }
 
@@ -574,7 +677,10 @@
 
   err = cons_init ();
   if (err)
+   {
+      endwin ();
     error (5, err, "Console library initialization failed");
+   }
 
   cons_server_loop ();
 


-- 
/^\
\ /     ASCII RIBBON CAMPAIGN
 X        AGAINST HTML MAIL
/ \