Re: Hurd bug in libdiskfs (patch included)

[Thomas Bushnell, BSG]

lilachaze <rgs26@cam.ac.uk> writes:

> Hi.
> 
> libdiskfs has a nasty bug moving directories in a special case:
> 
> If the source dir's parent is not writable by you, but the dir itself is, and
> you try to move it, the ext2fs server crashes leaving your fs corrupted. The
> cause is that it doesn't check to see if the source dir's parent is writable
> before starting the move operation.
> 
> I've put a call to fshelp_checkdirmod in. To apply the patch:

It seems to me that in the case you describe, an error should be
returned by the first lookup in step one of dir-renamed.c; why does
this result in a crash?