bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: init patch


From: James A Morrison
Subject: Re: init patch
Date: Wed, 22 Jan 2003 10:43:27 -0500 (EST)

 These patches are unrelated.  One has to do with finding the initial
translators: proc, auth; the other, yours, has to do with initialization of
the system: runsystem.

 Make sense?

However, here is probably a better version of your patch, since it
uses crash_system().  Returning err, causes launch_something () to retry
start_child as it needs to and crashes the system if nothing works.

James A. Morrison

2003-01-22  James A. Morrison  <ja2morri@uwaterloo.ca>

        * init.c (start_child): Return err on error.

Index: init.c
===================================================================
RCS file: /cvsroot/hurd/hurd/init/init.c,v
retrieving revision 1.129
diff -u -r1.129 init.c
--- init.c      8 May 2002 09:20:38 -0000       1.129
+++ init.c      22 Jan 2003 15:37:14 -0000
@@ -1,6 +1,6 @@
 /* Start and maintain hurd core servers and system run state
 
-   Copyright (C) 1993,94,95,96,97,98,99,2000,01,02
+   Copyright (C) 1993,94,95,96,97,98,99,2000,01,02,03
        Free Software Foundation, Inc.
    This file is part of the GNU Hurd.
 
@@ -1028,7 +1029,8 @@
        err = argz_create ((char **) argv, &args, &arglen);
       }
     }
-  assert_perror (err);
+  if (err)
+    return err;
 
   file = file_name_lookup (args, O_EXEC, 0);
   if (file == MACH_PORT_NULL)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]