[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH (long)] hello.c follow-up
From: |
PUYDT Julien |
Subject: |
Re: [PATCH (long)] hello.c follow-up |
Date: |
20 Jul 2003 17:55:55 +0200 |
Le dim 20/07/2003 à 16:49, Alfred M. Szmidt a écrit :
> This ChangeLog is just bogus. Please read the GNU Coding Standard on
> how to format, and write the entries (hint: Emacs' C-x 4 a
> (add-change-log-entry-other-window) binding is very nice!)
I don't see how this ChangeLog entry is bogus, in light of for example
the entries around lines 240-262, or around lines 658-680, of
$(HURD)/libtrivs/Changelog, but since you complain, let's try another
presentation:
2003-07-18 Julien PUYDT <julien.puydt@laposte.net>
* hello.c
Cut some comments, obsoleted by the addition of functions
(trivfs_modify_stat): struct stat -> io_statbuf_t
(trivfs_S_io_seek): off_t -> loff_t, and check for offset sanity
(trivfs_S_io_get_openmodes):Added, to comply with asserts in
libtrivfs
(trivfs_S_io_clear_some_openmodes): Likewise
(trivfs_S_io_set_some_openmodes): Likewise
(trivfs_S_io_set_all_openmodes): Likewise
(trivfs_S_io_readable): Likewise
(trivfs_S_io_select): Likewise
As usual, _constructive_ advices and comments are welcome,
Snark on #hurd, #hurdfr