Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c

[Ognyan Kulev]

Alfred M. Szmidt wrote:
> Please don't use {} in ChangeLogs.

You're right.  An updated changelog is attached.

Regards
--
Ognyan Kulev <ogi@{fmi.uni-sofia.bg,fsa-bg.org}>
7D9F 66E6 68B7 A62B 0FCF  EB04 80BF 3A8C A252 9782

2003-07-27  Ognyan Kulev  <ogi@magid.fmi.uni-sofia.bg>

        * dir-renamed.c (checkpath): Redundant assignment is removed.
        (diskfs_rename_dir): Remove variable BUF.
        Space for DS is allocated with alloca.
        When renaming node to itself, goto out instead of repeating code.
        When checking if TNP is empty directory, assertion "!err" is
        checked.
        Check early if we can remove FROMNAME.  This implicitly locks FNP,
        so the explicit locking of FNP is removed.
        When maximum link count of TDP is reached, goto out instead of
        returning immediately.
        When maximum link count of FNP is reached, goto out instead of
        repeating code.
        diskfs_node_update FNP only if diskfs_synchronous.
        After entering entry TONAME to TDP, set DS to 0.
        When preparing to remove FROMNAME from FDP, use TMPDS instead of
        DS.  Fix the assertion so that it can handle errors.  If error
        occur, diskfs_drop_dirstat TMPDS before goto out.

        * dir-rename.c (diskfs_S_dir_rename): Now really serialize
        directory renaming with RENAMEDIRLOCK.
        When renaming directory, don't diskfs_node_update and
        diskfs_file_update because dir-renamed.c::diskfs_rename_dir
        already do it.
        When TONAME is .. of filesystem's root, not only set ERR to
        EINVAL, but return this error.
        When EXCL is set and target exist, unlock things properly.
        When FROMNAME is regular file and TONAME is directory, unlock TNP
        before returning.
        When maximum link count of FNP is reached and TNP is not NULL,
        unlock TNP before returning.
        When updating FNP after incrementing its link count, call
        diskfs_node_update only if diskfs_synchronous.
        After TONAME enters TDP, call diskfs_file_update instead of
        diskfs_node_update.