[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch #1599] [Patch #1599] store_typed_open on file name doesn't ca
From: |
James Morrison |
Subject: |
Re: [patch #1599] [Patch #1599] store_typed_open on file name doesn't call store_open |
Date: |
Fri, 1 Aug 2003 07:37:25 -0400 (EDT) |
> From: noreply@savannah.gnu.org
> X-Savannah-Server: savannah.gnu.org:443 [199.232.41.3]
> X-Savannah-Project: hurd
> X-Savannah-Artifact: patch
> X-Savannah-Artifact-ID: 1599
> X-Apparently-From: 212.23.136.22
> Date: Thu, 31 Jul 2003 17:17:39 -0400
> Cc:
> Sender: bug-hurd-bounces+ja2morri=student.math.uwaterloo.ca@gnu.org
> X-Spam-Status: No, hits=2.9 required=5.0
> tests=SUBJ_HAS_SPACES,NO_REAL_NAME,SUPERLONG_LINE version=2.20
> X-Spam-Level: **
>
> Patch #1599 has been updated.
>
> Project:
> Category: libstore
> Status: Closed
> Summary: store_typed_open on file name doesn't call store_open
>
> Follow-Ups:
>
> Date: Thu 07/31/2003 at 23:17
> By: marcus
>
> Comment:
> This patch is definitely wrong. The code should do the following:
>
> FOO:BAR - Open the class FOO with parameter BAR
> FOO: - Open the class FOO with no parameter
> :BAR - Open the file BAR (with store_open)
> BAZ - Try to find a class BAZ, and open that with no parameter, but if class
> is not found, open file BAZ with store_open.
From what I remember while looking at this problem we'd get passed the code
where FOO:BAR, FOO:, and :BAR where looked at then try to decide about BAZ.
BAZ would be looked up in a dl opened library which caused a segfault. This
means that we currently don't get back to the point where store_typed_open
calls store_open on BAZ. If we could get passed looking up BAZ as a class
we would get to store_opening BAZ as a file which should fix parted.
Jim
- Re: [patch #1599] [Patch #1599] store_typed_open on file name doesn't call store_open,
James Morrison <=