Re: [Fwd: [patch #2508] ext2fs support for large store (> 1.5G)]

[Marcus Brinkmann]

On Sat, Feb 07, 2004 at 01:23:12AM +0100, Marco Gerards wrote:
> The changelogs can use some work AFAICS.  For example you notice when
> you add new local variables, I would not do this.

It's ok to do this, in fact, it's correct.  Only if you add new functions
etc, or do a total rewrite, you are relieved from listing each and every
change.

> And I noticed you include the ChangeLog entries in the patch,
> personally I don't like this, also because you already included it.

The reason not to do it is not personal dislike/like, but because ChangeLogs
are always appended to at the top, so any other change done in the meantime
will break the patch, so it won't apply in that case.

However, if you do include the ChangeLog separately, it's a good idea to
make sure tabs won't be expanded to spaces (it's not critical if you don't
do that, but it's nicer).

> I wanted to test the patch before reading it in detail, so I just
> did.  When I used it on a small partition it worked for me.

I'd also be interested in some performance measurements, just to be sure
that it doesn't go down by orders of magnitude (compared to small-e2fs).
Also, as soon as it stabilized, long-time experience is required (ie,
massive compilations etc).

> > The patch requires changes in libpager and I don't claim they've been
> > done in the best way.  For example, ABI compatibility of libpager is
> > broken by this patch.  Again, just specify what should be changed in
> > the patch.
> 
> Is there any way to prevent breaking the ABI?  And do you think the
> changes can be made in a better way?

Not breaking the ABI of libpager is not important.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    marcus@gnu.org
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de/