Re: GNU Mach 1.x patch

[Alfred M. Szmidt]

   Jeff had some comments on my previous patch:
   http://mail.gnu.org/archive/html/bug-hurd/2004-01/msg00090.html

   I did not change this because I do not have enough knowledge about
   autoconf. Is the patch ok like it is now or should the patch be
   changed like Jeff said? I need a bit more help in that case.

Just do as Jeff told you.  Say that you have

,----
| AC_ARG_ENABLE(kdb,
| [  --enable-kdb             enable use of in-kernel debugger],
| [test "x$enableval" = xno || AC_DEFINE(MACH_KDB, 1, [enable use of in-kernel 
debugger])])
`----

Change that to:

,----
| AC_ARG_ENABLE([kmsg],
|  AC_HELP_STRING([--enable-kmsg],
|  [enable use of kmsg device [default=yes]], 
|  [test "x$enableval" = xno || AC_DEFINE(MACH_KDB, 1, [enable use of in-kernel 
debugger])]))
`----

And you are done...

As for the _LOCAL changes that Jeff talked about, I don't really
understand his comment about "bootstraping".  If something like
"./configure && make install-headers" works with your patch, then
bootstraping shouldn't be a problem.  Jeff, could you be more specific
about your concern?

   The NEWS entry was removed and so was the keyboard patch because it
   is already in CVS.

The NEWS entry isn't in CVS, but I would like to see it fixed.
Specially if there is going to be a 1.4 release.

   How about using savannah's feature to send CC's to some
   mailadresses for bug reports, patches, etc.?  I could include
   bug-hurd@gnu.org there, although it is better that savannah would
   be fixed.  I'm just asking because it might be possible people are
   interested in this and do not know about this possible workaround.

How about just sending the patch to the mailing list in the first
place?  That has worked since the begining of time. :-)


By the way, could you try this with autoconf 2.59?  This is the latest
version of autoconf.  If it works, goodie, if not, the patch will have
to be tweaked, and the required autoconf version updated (unless it
will still work with <2.59)


   2004-03-01  Marco Gerards  <metgerards@student.han.nl>

           * aclocal.m4: (AC_PROG_CC_LOCAL): Macro removed.
           (AC_PROG_CC_WORKS_LOCAL): Likewise.
           * configure.in: Update AC_INIT to contain the version, bug address
           and program name.  Changed the version to 1.4.  Use
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^

Changed the version of what?  "Bumped GNU Mach version to 1.4" is far
clearer.

   Index: configure.in
   ===================================================================
   RCS file: /cvsroot/hurd/gnumach/configure.in,v
   retrieving revision 1.12
   diff -u -p -r1.12 configure.in
   --- configure.in     23 May 2002 00:06:36 -0000      1.12
   +++ configure.in     29 Feb 2004 13:23:46 -0000
[...snip....]
   @@ -56,13 +51,10 @@ AC_ARG_ENABLE(kmsg,

    AC_PROG_INSTALL
    AC_PROG_AWK
   -
   -AC_CHECK_TOOL(CC, gcc)
   -# That check handles cross-compilation well, but AC_PROG_CC tests for GCC
   -# and sets default CFLAGS nicely for us, so do that too.
   -AC_PROG_CC_LOCAL
   +AC_PROG_CC

    AC_CHECK_TOOL(LD, ld)
   +AC_SUBST(LDFLAGS)

I still do not understand the need for the AC_SUBST(LDFLAGS) here or
in i386/linux/Drivers.in.  Could you explain why it is needed?


Anyway, the patch has my blessing (if that is worth anything) with or
without my suggestions in this mail, the only "show-stopper" is Jeff's
concerns about the _LOCAL macro changes.

Cheers.