bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #2507] Patch to update autoconf files


From: Alfred M. Szmidt
Subject: Re: [patch #2507] Patch to update autoconf files
Date: Tue, 07 Sep 2004 15:37:54 +0200

   >     "Comment out the u1434f and viarhine drivers which break
   >     autoconf."
   > 
   > Is there any good reason why not just fix those two drivers to be
   > sane and work with autoconf?

   No, feel free.

Then why do you bother sending in a broken patch? Disabling drivers
for the sake of laziness is silly.  People actually do use the via
rhine driver, I have no idea about uf143f but that is still no reason
to disable drivers...

This patch shouldn't be committed since it breaks existing
functionality (the viarhine and u143f drivers) without any good
reason.


PS.  I was asking for _technical_ reasons on why you disabled those
drivers.  Not some fluffy puffy stuff... :-)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]