Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

[Neal H. Walfield]

At Tue, 30 Nov 2004 12:19:22 +0100,
Alfred M. Szmidt wrote:
> 
>    > I agree with Neal. I can test it before I commit it as Neal
>    > requested.
>    > 
>    > Roland, OK to commit?
> 
>    That looks fine to me.
> 
> Guillem didn't tell me that this will cause a bunch of asserts to
> happen if Neal's patches (no idea which) aren't applied _first_.
> 
> Infact, the welcome message for me when I booted the kernel was a
> assert in linux/dev/glue/kmem.c line 470 right after partition checks.
> 
> Should I still commit it even if it breaks peoples kernels for now?
> 
> And could someone be kind enough to post whatever "Neal's patches" are
> so that they can be check and blessed?

Sounds like it might be this [1] patch.

patch #3347 overview: Double free and memory loss probing partition
table

"While GNU Mach reads the partition table, the second assert in
linux/dev/glue:free_pages is triggered. This particular assert checks
for double frees."

[1] https://savannah.gnu.org/patch/?func=detailitem&item_id=3347