[patch #2715] diskfs optimization

[Neal H. Walfield]

This mail is an automated notification from the patch tracker
 of the project: The GNU Hurd.

/**************************************************************************/
[patch #2715] Latest Modifications:

Changes by: 
                Neal H. Walfield <neal@cs.uml.edu>
'Date: 
                Fri 12/03/04 at 09:51 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Roland says:

%d format is canonical for the /servers/socket/ file names.
That code presumes the PF_LOCAL macro will be defined that way.  It could
be any constant expression, an enum, hex, arithmetic, whatever.  Don't
assume the headers won't change in ways they are permitted to.  The
compiler may optimize away sprintf when the format and arguments are all
constant.  That will have to be enough.








/**************************************************************************/
[patch #2715] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=2715>
Project: The GNU Hurd
Submitted by: Marcus Brinkmann
On: Sat 02/28/04 at 20:48

Category:  libdiskfs
Priority:  3 - Low
Resolution:  Invalid
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Closed


Summary:  diskfs optimization

Original Submission:  A small optimization for ifsock.c by Neal Walfield:

2001-06-20  Neal H Walfield  <neal@cs.uml.edu>

        * ifsock.c (diskfs_S_ifsock_getsockaddr): Don't use sprint
        when we can just use the preprocessor.



Follow-up Comments
------------------


-------------------------------------------------------
Date: Fri 12/03/04 at 09:51         By: Neal H. Walfield <neal>
Roland says:

%d format is canonical for the /servers/socket/ file names.
That code presumes the PF_LOCAL macro will be defined that way.  It could
be any constant expression, an enum, hex, arithmetic, whatever.  Don't
assume the headers won't change in ways they are permitted to.  The
compiler may optimize away sprintf when the format and arguments are all
constant.  That will have to be enough.








File Attachments
-------------------

-------------------------------------------------------
Date: Sat 02/28/04 at 20:48  Name: neal-diskfs-20010620  Size: 1.24KB   By: 
marcus

http://savannah.gnu.org/patch/download.php?item_id=2715&amp;item_file_id=2819






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=2715>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/