Re: [Linux 2.6 PATCH] support for Hurd ext2 format extensions

[Michael Banck]

On Mon, Mar 01, 2004 at 05:32:39PM -0800, Roland McGrath wrote:
> Here is a new version of the patch.  Please let me know how it works for you.

I had another look at this, for possibly submitting it to the Debian
kernel team. I noticed one thing:

> Index: fs/ext2/xattr.c
> ===================================================================
> RCS file: /home/roland/redhat/bkcvs/linux-2.5/fs/ext2/xattr.c,v
> retrieving revision 1.20
> diff -b -p -u -r1.20 xattr.c
> --- fs/ext2/xattr.c   6 Feb 2004 16:50:15 -0000       1.20
> +++ fs/ext2/xattr.c   28 Feb 2004 23:22:53 -0000
> @@ -892,6 +924,14 @@ ext2_xattr_delete_inode(struct inode *in
>  
>  cleanup:
>       brelse(bh);
> +#ifdef CONFIG_EXT2_FS_XATTR_HURD
> +     printk("dropping inode %ld translator %u\n",
        ^^^^^^
> +            inode->i_ino, EXT2_I(inode)->i_hurd_translator);
> +     if (EXT2_I(inode)->i_hurd_translator != 0) {
> +             ext2_free_blocks(inode, EXT2_I(inode)->i_hurd_translator, 1);
> +             EXT2_I(inode)->i_hurd_translator = 0;
> +     }
> +#endif
>       up_write(&EXT2_I(inode)->xattr_sem);
>  }
>  

It seems this printk() is the only thing somebody might notice if he has
no -o hurd paritions at all. Shouldn't this rather be inside the if()
statement, or did I miss something? Do I perhaps have an out-of-date
version of the patch?

On my box, I have:

nighthawk~/debian/upload$ sudo zgrep dropping /var/log/messages* | 
        grep translator | wc -l
6515
nighthawk~/debian/upload$ sudo zgrep dropping /var/log/messages* | 
        grep -v translator\ 0  | wc -l
8

I.e., only 8 of those messages are from an actual translator, AFAICT.


cheers,

Michael