Re: new version of glibc xattr patch

[Barry deFreese]

----- Original Message ----- 
From: "Roland McGrath" <roland@frob.com>
To: <bug-hurd@gnu.org>
Sent: Sunday, March 06, 2005 6:58 PM
Subject: new version of glibc xattr patch


> This adds the missint {f,}{list,remove}xattr functions.
> Not tested in the slightest.

OK, so I am trying to rebuild glibc with your new patch.  I am getting an 
error on size in fremovexattr.c.  It is because it is not defined.  Here is 
the code:

int
fremovexattr (int fd, const char *name)
{
 error_t err;

 err = HURD_DPORT_USE (fd, _hurd_xattr_remove (port, name));

 return err ? __hurd_dfail (fd, err) : size;
}


Here is what it looks like in fgetxattr.c:

ssize_t
fgetxattr (int fd, const char *name, void *value, size_t size)
{
 error_t err;

 err = HURD_DPORT_USE (fd, _hurd_xattr_get (port, name, value, &size));

 return err ? __hurd_dfail (fd, err) : size;
}


What should the return err ? code be instead of size, name?

Thanks,

Barry deFreese (aka bddebian)