buglet in pflocal/sock.c

[Neal H. Walfield]

sock_free incorrectly frees SOCK->CONNECT_QUEUE.  This is only used in
S_socket_connect to mark a socket as having a connection in progress.
It is set to SOCK's peer's listen_queue and thus should not be
deallocated.

Okay to apply?

Thanks,
Neal

pflocal/

2005-05-17  Neal H. Walfield  <neal@gnu.org>

        * sock.c (sock_free): Don't destroy SOCK->CONNECT_QUEUE.


Index: sock.c
===================================================================
RCS file: /cvsroot/hurd/hurd/pflocal/sock.c,v
retrieving revision 1.29
diff -u -p -r1.29 sock.c
--- sock.c      24 Apr 2002 16:30:07 -0000      1.29
+++ sock.c      17 May 2005 09:46:05 -0000
@@ -1,6 +1,6 @@
 /* Sock functions
 
-   Copyright (C) 1995,96,2000,01,02 Free Software Foundation, Inc.
+   Copyright (C) 1995,96,2000,01,02, 2005 Free Software Foundation, Inc.
    Written by Miles Bader <miles@gnu.org>
 
    This program is free software; you can redistribute it and/or
@@ -138,8 +138,6 @@ sock_free (struct sock *sock)
     mach_port_destroy (mach_task_self (), sock->id);
   if (sock->listen_queue)
     connq_destroy (sock->listen_queue);
-  if (sock->connect_queue)
-    connq_destroy (sock->connect_queue);
   free (sock);
 }