Re: Making the hurd console accessible to blind users

[Samuel Thibault]

Hi,


Marcus Brinkmann, le Mon 11 Jul 2005 16:04:58 +0200, a écrit :
> At Mon, 23 May 2005 20:52:02 +0200,
> Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > 
> > [1  <text/plain; us-ascii (7bit)>]
> > Hi,
> > 
> > Now that FSF got my papers signed back, here is again my patch to let
> > screen readers like brltty work with the Hurd. As discussed and agreed
> > on some time ago on #hurd (and ##hurd), it extends Marco's console
> > repeater translator to handle symlinks, and adds a vcs repeater that
> > maintains a symlink to the currently showed console. One can switch
> > console by mksymlink()ing it.
> 
> thanks a lot for this!

Thanks a lot to have commited it ! :)

It seems all ok, except that in my latest patch, the repeater_node
variable of current-vcs.c has a default value of DEFAULT_REPEATER_NODE,
because else it would segfault if one loads the driver without
specifying a repeater node (patch below).

Thanks again,
Samuel

Index: console-client/current-vcs.c
===================================================================
RCS file: /cvsroot/hurd/hurd/console-client/current-vcs.c,v
retrieving revision 1.1
diff -u -r1.1 current-vcs.c
--- console-client/current-vcs.c        11 Jul 2005 13:59:24 -0000      1.1
+++ console-client/current-vcs.c        12 Jul 2005 23:04:32 -0000
@@ -32,7 +32,7 @@
 #define DEFAULT_REPEATER_NODE "vcs"
 
 /* The name of the repeater node.  */
-static char *repeater_node;
+static char *repeater_node = DEFAULT_REPEATER_NODE;
 
 /* The repeater node.  */
 static consnode_t vcs_node;